Skip to content

[PM-41830] Shrinking Window Causes Buttons to Overlap Owner Element and Pushes More Options Menu Offscreen - #22419

Merged
jengstrom-bw merged 3 commits into
mainfrom
vault/pm-41830/shrinking-window-causes-buttons-to-overlap-owner-element-and-pushes-more-optinos-menu-offscreen
Aug 18, 2026
Merged

[PM-41830] Shrinking Window Causes Buttons to Overlap Owner Element and Pushes More Options Menu Offscreen#22419
jengstrom-bw merged 3 commits into
mainfrom
vault/pm-41830/shrinking-window-causes-buttons-to-overlap-owner-element-and-pushes-more-optinos-menu-offscreen

Conversation

@jengstrom-bw

@jengstrom-bw jengstrom-bw commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

Jira

📔 Objective

When shrinking the desktop window, the buttons will eventually overlap the Owner column elements and will push the More Options three dot menu offscreen. The overlap happens on both Login and Card ciphers, but the More Options issue only happens on Login ciphers. This PR fixes the overlap and pushing issues.

📸 Screenshots

Screen.Recording.2026-08-13.at.3.39.01.PM.mov

@jengstrom-bw jengstrom-bw added ai-review-vnext Request a Claude code review using the vNext workflow t:bugfix Change Type - Bugfix labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the desktop vault-v3 column sizing fix and the new quick copy actions toggle in the settings dialog. Verified the px column budget: bitIconButton renders tw-size-10 (40px) by default and tw-size-8 (32px) at size="small", quick copy tops out at three icons (Login), so launch + 3 icons + overflow trigger + padding stays under tw-w-56 (224px); bit-item-action adds no horizontal box, and bit-table layout="fixed" renders a single table so the header cells govern the virtual-scrolled rows. The @md → @xl Owner breakpoint is now consistent across the header and both row templates (all inside the same tw-@container), @xl resolves from the @tailwindcss/container-queries plugin (only @3xl/@5xl are overridden in tailwind.config.base.js), and the tw-w-40/tw-w-56 strings in the .ts file are picked up because the desktop Tailwind content glob includes ./src/**/*.{html,ts,mdx}. On the settings side, VaultCopyButtonsService is providedIn: "root" so the non-optional inject() in VaultListComponent is safe, the new showQuickCopyActions control mirrors the existing settings.component implementation (same flag gate, firstValueFrom initialization, and (change) save handler as neighboring checkboxes), and showQuickCopyActionsInVault already exists in the desktop locale.

Code Review Details

No findings.

@codecov

codecov Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.06%. Comparing base (c8fd6e8) to head (e235bbc).
⚠️ Report is 41 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...top/src/vault/app/vault-v3/vault-list.component.ts 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22419      +/-   ##
==========================================
+ Coverage   53.92%   54.06%   +0.14%     
==========================================
  Files        4297     4307      +10     
  Lines      136500   136754     +254     
  Branches    21569    21610      +41     
==========================================
+ Hits        73612    73942     +330     
+ Misses      57522    57419     -103     
- Partials     5366     5393      +27

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jengstrom-bw
jengstrom-bw marked this pull request as ready for review August 14, 2026 15:20
@jengstrom-bw
jengstrom-bw requested a review from a team as a code owner August 14, 2026 15:20
nick-livefront
nick-livefront previously approved these changes Aug 14, 2026
View reviewed changes
Comment thread apps/desktop/src/vault/app/vault-v3/vault-list.component.ts
export const RowHeightClass = `tw-h-[76.5px]`;

/**
* Width of the Options column, sized to the widest action strip a row can draw.

@nick-livefront nick-livefront Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Documentation is appreciated!

@djsmith85 djsmith85 added the desktop Desktop Application label Aug 18, 2026
@jengstrom-bw
jengstrom-bw merged commit d53ebf3 into main Aug 18, 2026
145 of 149 checks passed
@jengstrom-bw
jengstrom-bw deleted the vault/pm-41830/shrinking-window-causes-buttons-to-overlap-owner-element-and-pushes-more-optinos-menu-offscreen branch August 18, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nick-livefront nick-livefront nick-livefront approved these changes
@jaasen-livefront jaasen-livefront Awaiting requested review from jaasen-livefront jaasen-livefront is a code owner automatically assigned from bitwarden/team-vault-dev

Assignees

No one assigned

Labels

ai-review-vnext Request a Claude code review using the vNext workflow desktop Desktop Application t:bugfix Change Type - Bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jengstrom-bw @nick-livefront @djsmith85